Confirm dialog: use more descriptive text for the confirm button #60364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +63 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/confirm-dialog-confirm-button-text
branch
from
912357a
to
43e8471
Compare
afercia
force-pushed
the
fix/confirm-dialog-confirm-button-text
branch
from
879d64c
to
f4e8e3b
Compare
|
I updated the text for the 'edit template' confirm dialog as suggested in #60360 (comment) Cc @noisysocks |
afercia
force-pushed
the
fix/confirm-dialog-confirm-button-text
branch
from
f4e8e3b
to
7a284fc
Compare
noisysocks
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60360
What?
Some of the
ConfirmDialginstances use the generic, default 'OK' text for the confirm button. They should use a more descriptive text.Also, ideally the confirm dialog copy should always ask a question.
Why?
A more descriptive text helps users better understand what the 'confirm' action does. Also, the
ConfirmDialgwas implemented with the purpose of providing a more descriptive text than the generic 'OK'.How?
Provides a more descriptive text for the copy and the confirm button.
Testing Instructions
Would you like to edit the template this block is part of?.Are you sure you want to apply this revision? Any unsaved changes will be lost..Testing Instructions for Keyboard
Screenshots or screencast