ESLint: Enable and enforce remaining i18n rules for the plugin (e.g. no trailing spaces) #60196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Internationalization (i18n)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +100 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
CI reports: These warnings are unrelated but errors can be easily fixed. |
|
#59835 should fix many of these errors |
swissspidy
changed the title
swissspidy
requested review from
spacedmonkey,
draganescu,
adamziel,
kevin940726,
ellatrix and
ajitbohra
as code owners
gziolo
approved these changes
Aug 21, 2024
Yes that makes sense to me. The rules were added in #38225 for React Native / Android in mind, but as you can see here they're useful in general. Apparently I asked about this before in #19777 (comment) but never got an answer why this wasn't enabled by default everywhere. |
Right, I see it now. Yes, let's add it in a follow-up and land the changes for Gutenberg for now 🚀 |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…no trailing spaces) (WordPress#60196) Co-authored-by: Mahesh Bohara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These two ESLint rules are available in the ESLint plugin but are not enabled by default. This enables them for the Gutenberg repository.
Includes changes from #59835 to remove trailing spaces (props @maheshbohara)
Why?
Because GB should follow i18n best practices :-)
How?
Testing Instructions
createInterpolateElement(e.g. the welcome guide) should still render with the proper linkTesting Instructions for Keyboard
Screenshots or screencast