-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured Image: Fix block support selectors after shadow support addition #60184
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing nicely for me, thanks for the follow-up @aaronrobertshaw! Tested with a couple of different Featured Image patterns in the post and site editors with a mix of local-to-the-block and global styles, and it's all testing nicely for me 👍
LGTM! ✨
Thanks for lightning fast followup. This does indeed appear to work as intended. CC: @bph, can we cherry-pick this one for GB 18.0? Since the featured image radius is such a prominent feature of Twenty Twenty-Four, it would be a good one to include. |
I just cherry-picked this PR to the release/18.0 branch to get it included in the next release: 1cd464d |
Related:
What?
Fixes broken border radius and duotone block supports on the featured image block.
Note: Any odd behaviour with the location and display of the overlay was fixed in #60187
Why?
When shadow block support was added to the featured image block it used the Block Selectors API. When this is used theme.json and global styles expect all block supports selectors to be configured by the same approach i.e. the selectors API or the old
__experimentalSelectors
properties but not both.How?
Moves the selectors for duotone and borders support to the selectors API within the block.json file.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-26.at.10.46.49.AM.mp4