Fix code formatting in Nav block view file #60162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Once merged let's bring this into #60157 |
getdave
commented
Mar 25, 2024
| }, | ||
| closeMenuOnHover() { | ||
| const { type, overlayOpenedBy } = getContext(); | ||
| if ( | ||
| type === 'submenu' && | ||
| // Only open on hover if the overlay is closed. | ||
| // Only close on hover if the overlay is closed. |
There was a problem hiding this comment.
I'm confused as to why we close on hover when something is closed...
There was a problem hiding this comment.
Because if overlay is open the submenu should not be closed as it's always expanded.
|
Size Change: 0 B Total Size: 1.72 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Mar 25, 2024
getdave
added
the
Backport to WP 6.7 Beta/RC
bph
added
the
Backport to Gutenberg RC
bph
pushed a commit
that referenced
this pull request
Mar 26, 2024
|
I just cherry-picked this PR to the release/18.0 branch to get it included in the next release: fc77423 |
bph
removed
the
Backport to Gutenberg RC
getdave
added a commit
that referenced
this pull request
Mar 27, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
getdave
added
Backported to WP Core
|
I just cherry picked this into WP 6.5 RC 4 branch 13a77c7 |
getdave
added a commit
that referenced
this pull request
Mar 27, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes code formatting as identified in #60157 (comment)
Why?
How?
Code
Testing Instructions
Run testing steps from #60130.
Testing Instructions for Keyboard
Screenshots or screencast