Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @kevin940726 and @Mamaduka from e2e test codeowners #60067

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

kevin940726
Copy link
Member

What?

Remove @kevin940726 from e2e test codeowners.

Why?

Now that the migration is (nearly) done, and most of the contributors are more familiar with writing playwright tests, I don't think I need to be pinged on every PR that touches tests anymore. Also, It's kind of overwhelming and I have less time to help on tests now 😅.

How?

Edit CODEOWNERS.

Testing Instructions

Nothing to test.

Screenshots or screencast

N/A

@kevin940726 kevin940726 added the [Type] Project Management Meta-issues related to project management of Gutenberg label Mar 21, 2024
@kevin940726 kevin940726 requested a review from Mamaduka March 21, 2024 09:38
@kevin940726 kevin940726 self-assigned this Mar 21, 2024
@kevin940726 kevin940726 requested a review from desrosj as a code owner March 21, 2024 09:38
@kevin940726
Copy link
Member Author

@Mamaduka Do you want to do the same? 😆

Copy link

github-actions bot commented Mar 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: kevin940726 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka
Copy link
Member

You're making a good point, and yes, please!

@kevin940726 kevin940726 changed the title Remove @kevin940726 from e2e test codeowners Remove @kevin940726 and @Mamaduka from e2e test codeowners Mar 21, 2024
@kevin940726 kevin940726 enabled auto-merge (squash) March 21, 2024 10:03
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kevin940726!

Copy link

Flaky tests detected in b9cfefd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8373046179
📝 Reported issues:

@kevin940726 kevin940726 merged commit 2f93eb3 into trunk Mar 21, 2024
57 checks passed
@kevin940726 kevin940726 deleted the fix/remove-e2e-codeowner branch March 21, 2024 10:34
@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 21, 2024
@bph bph added the [Type] Build Tooling Issues or PRs related to build tooling label Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Type] Automated Testing, [Type] Project Management.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@bph bph added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. and removed [Type] Build Tooling Issues or PRs related to build tooling labels Mar 21, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
…#60067)

Co-authored-by: kevin940726 <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

* Remove kevin940726 from e2e test codeowners

* Remove Mamaduka from test e2e codeowners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants