Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency-extraction-webpack-plugin docs #59973

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

enodekciw
Copy link
Contributor

requestToHandle is example is wrong. It shows requestToExternal being passed into the plugin, but function name is different.

What?

Fixes an example code for requestToHandle

image

requestToHandle example fixed
@enodekciw enodekciw requested a review from gziolo as a code owner March 18, 2024 22:52
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @enodekciw.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: enodekciw.


To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @enodekciw! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 18, 2024
@Mamaduka Mamaduka added [Type] Developer Documentation Documentation for developers [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin labels Mar 19, 2024
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @enodekciw!

@Mamaduka Mamaduka merged commit 502b0bd into WordPress:trunk Mar 19, 2024
59 of 60 checks passed
Copy link

Congratulations on your first merged pull request, @enodekciw! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 18.0 milestone Mar 19, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Mar 27, 2024
Unlinked contributors: enodekciw.

Co-authored-by: Mamaduka <[email protected]>
@enodekciw enodekciw deleted the patch-1 branch August 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Tool] Dependency Extraction Webpack Plugin /packages/dependency-extraction-webpack-plugin [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants