Global Styles: Remove preset headers #59504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
remove/preset-headers
branch
from
c5d57c0
to
cf24123
Compare
|
Excited about this work. I hope you don't mind some feedback that's not entirely related to preset heading . I understand the allure of surfacing all colour and font cards here , but I'm concerned it's going to distract from other controls, particularly because I assume in most cases the colour/font sets would only be set once vs other more granular controls as they are fine tuned. I can also imagine themes shipping with lots of options which would push everything down. Could we try a more progressive approach? In recent block styles work we are showing active variation and then other options in dropdown on click. Cc @richtabor |
This was my feeling too and that's how #56622 was at one point but then @richtabor and @mtias thought it was better higher. I don't feel strongly either way. |
scruffian
force-pushed
the
remove/preset-headers
branch
from
cf24123
to
b13fa98
Compare
|
While working on #59508 I noticed inconsistency in the way the global styles Variations are named in the editor UI. While I agree 'Presets' didn't make much sense, I do think this section of content should be clearly identified. Right now;
I'll create a separate issue to propose to restore these headings and always use the term 'variation' because that's what they are. It is also not very clear they are provided by the theme, which should be explained to users in some way. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the "Preset" headers from Color and Typography sections.
Why?
They are unnecessary.
How?
Removes the code
Testing Instructions
Screenshots or screencast