-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation: Add missing empty space to print out valid HTML. #59255
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gyurmey2. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in c95a2ee. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8002508355
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @juanfra!
Unlinked contributors: gyurmey2. Co-authored-by: juanfra <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]>
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 266b4d2 |
Unlinked contributors: gyurmey2. Co-authored-by: juanfra <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]>
What?
Adding an empty space to have the navigation block producing valid HTML.
Fixes #59238
Why?
Because if not, there are two attributes together.
How?
Adding an empty space.
Testing Instructions
data-wp-interactive="core/navigation"
and the following data attribute of thenav
element.