getDirectInsertBlock: Remove 'directInsert' as a callback handler #59172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +46 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
Mamaduka
requested review from
jsnajdr and
tellthemachines
and removed request for
juanmaguitar,
ajitbohra and
ryanwelcher
|
Flaky tests detected in 05f8c3c8313e9e4449ff3adc9386e84663201372. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7959228136
|
noisysocks
previously requested changes
Feb 21, 2024
There was a problem hiding this comment.
Tests well, thanks for the nice cleanup.
There's a JSDoc here that needs updating:
Since InnerBlocks is a public API this is technically a breaking change.
I can't find any usage of the API in wpdirectory.net and it was only ever documented via the useNestedSettingsUpdate JSDoc which is pretty obscure so I think it's acceptable to output a deprecated() warning in useNestedSettingsUpdate and no longer support the behaviour.
Mamaduka
force-pushed
the
cleanup/get-direct-insert-block
branch
from
05f8c3c
to
bdfcd07
Compare
|
@noisysocks, I added the deprecation notice. Screenshot
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes support for the
directInsertcallback value ingetDirectInsertBlock.Update: I've also removed selector memoization; now that data comes directly from the store, there's no need for that.
Why?
The logic was introduced as part of initial experiment #34899 but hasn't been used in the core for a while. The setting became a boolean after the stabilization. See #52083.
The block edit components are better suited to derive similar setting values based on the state and context.
Testing Instructions
Testing Instructions for Keyboard
Same.