Editor: Remove MoreDropdownMenuComponent #59096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
talldan,
draganescu,
adamziel and
kevin940726
as code owners
youknowriad
requested review from
ntsekouras,
gziolo and
talldan
and removed request for
draganescu,
adamziel,
talldan,
kevin940726,
ntsekouras and
gziolo
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
remove/more-dropdown-menu-component
branch
from
8628e57 to
74607b6
Compare
|
Size Change: -1.5 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 32da698. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8159010568
|
youknowriad
force-pushed
the
remove/more-dropdown-menu-component
branch
from
74607b6 to
1aa0c9c
Compare
youknowriad
force-pushed
the
remove/more-dropdown-menu-component
branch
from
1aa0c9c to
5bac357
Compare
ntsekouras
force-pushed
the
remove/more-dropdown-menu-component
branch
from
5bac357 to
32da698
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #59095
What?
This is another cleanup PR.
AFAIK, this component only has a label, an icon and position for the dropdown, I think that's not enough for a reusable component in the interface package.
Aside: I have a longer term goal to get rid of the "interface" package. I introduced the package initially but I think over time I've come to understand that it's a wrong abstraction: