Use disabled attribute to disable block mover buttons
#588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Focus] Accessibility (a11y)
aduth
approved these changes
May 1, 2017
| onClick={ onMoveUp } | ||
| icon="arrow-up-alt2" | ||
| disabled={ !! isFirst } |
There was a problem hiding this comment.
Lack of types make it not so obvious, but we should (and currently can) assume the incoming value is already a boolean.
|
I'm confident in the design aspects here, using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575.
Also darkens the color of a disabled block-mover button somewhat... before this change it is almost invisible. There are likely further changes needed here - see #587.