Remove menubar role and improve complementary area header semantics. #58740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +63 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1c2506e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7802382452
|
This was referenced Feb 7, 2024
…s-panel-header-menubar
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58313
What?
The Styles panel header contains an ARIA
role="menubar". That wraps some buttons. The menubar role is incorrectly used because:While the intent of the menubar role added in #51318 was good as it was meant to privide a little more context and an aria-label for the group of buttons, I think this role is incorrectly used for the reasons mentioned above. Also, these buttons are more 'toggle buttons' that toggle other UI parts. They are not command buttons like users would expect in an ARIA rop;e=menu.
Rather, I think the context can be improved by making the visible title in the header a H2 heading.
Why?
ComplementaryAreacomponent lack some context. By default, the visible title is only wrapped within a<strong>element, whether it's the defautl header or a custom header:<strong>{ title }</strong><strong>{ __( 'Styles' ) }</strong>How?
I'll create a follow-up to improve the functionality of the
titleandsmallScreenTitle, which is used in the 'small' header shown on small screens.Testing Instructions
Stylestext before the buttons is now a H2 heading.Testing Instructions for Keyboard
Screenshots or screencast