Interactivity API: Migrate everything to TypeScript, add missing comments and remove the use of "we" #58718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Code Quality
cbravobernal
requested review from
kevin940726,
Mamaduka,
luisherranz and
DAreRodz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
47 tasks
|
Size Change: -6 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
cbravobernal
force-pushed
the
nitpick/interactivity-avoid-we-multi-line-comments
branch
from
00173a0 to
e6c6506
Compare
cbravobernal
force-pushed
the
nitpick/interactivity-avoid-we-multi-line-comments
branch
from
e6c6506 to
5a7963b
Compare
cbravobernal
commented
Feb 9, 2024
| @@ -268,7 +204,7 @@ const resolve = ( path, namespace ) => { | |||
| }; | |||
|
|
|||
| // Generate the evaluate function. | |||
| export const getEvaluate: GetEvaluate = | |||
| export const getEvaluate: any = | |||
There was a problem hiding this comment.
Using GetEvaluate is returning this error:
Evaluate; ref: RefObject<HTMLElement>; attributes: createElement.JSX.HTMLAttributes<EventTarget>; }' is not assignable to type 'Scope'.
Types of property 'context' are incompatible.
Type 'DeepSignalObject<{}>' is missing the following properties from type 'Context<any>': Consumer, Provider
407 ? getEvaluate( { scope } )( eachKey[ 0 ] )
There was a problem hiding this comment.
I'll take a look, deep signal types can be complex 🙂
|
Flaky tests detected in 071db98. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7846609718
|
luisherranz
changed the title
|
Closing this PR for being outdated. Follow-up PRs will follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change multiline comments to block comments. Remove "we". Add TypeScript to the Interactivity API runtime.
Why?
Following WordPress contributing standards and code quality.