Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Remove use of Gutenberg_Navigation_Fallback class #58369

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

youknowriad
Copy link
Contributor

What?

I don't see where this class is being defined in the plugin. My guess is that this is a class that has been backported to WordPress a long time ago and there's no need for fallback now (since the class is not in the plugin anymore).

@youknowriad youknowriad added [Type] Code Quality Issues or PRs that relate to code quality [Block] Navigation Affects the Navigation Block labels Jan 29, 2024
@youknowriad youknowriad self-assigned this Jan 29, 2024
Copy link
Contributor

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youknowriad youknowriad merged commit 44df307 into trunk Jan 29, 2024
60 of 61 checks passed
@youknowriad youknowriad deleted the update/remove-gutenberg-navigation-fallback branch January 29, 2024 12:53
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants