Tooltip: Add test for classname leakage #58182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #57878
What?
Adds a unit test for the Tooltip component to assert that it doesn't leak the
components-tooltip
CSS classname onto the anchor element when tooltips are nested.Why?
Although Tooltip will in fact leak props to its anchor element in the nested case, it will likely not be much of a problem because consumers usually have no reason to set arbitrary props on Tooltip itself.
The test is specifically to guard against future devs from unwittingly connecting Tooltip to the Component Context System, which will automatically add and leak the
components-tooltip
class, causing visual breakage.Testing Instructions
Connect
Tooltip
to the Component Context System. Test should fail.Diff (Don't mind the TS errors)