Font Libary: Add missing translation functions #58104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
|
Size Change: -3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1213051. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7900397566
|
t-hamano
force-pushed
the
i18n/font-library-translate
branch
from
b79e14b
to
c3bb64c
Compare
t-hamano
requested review from
pbking,
matiasbenedetto,
creativecoder and
jffng
There was a problem hiding this comment.
Thanks for addressing this @t-hamano !
Some of these actually use the default text domain intentionally, because the strings are already translated in Core. See inline comments for details.
lib/experimental/fonts/font-library/class-wp-rest-font-collections-controller.php
Outdated
Show resolved
Hide resolved
lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php
Outdated
Show resolved
Hide resolved
lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php
Outdated
Show resolved
Hide resolved
lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php
Outdated
Show resolved
Hide resolved
t-hamano
force-pushed
the
i18n/font-library-translate
branch
from
c3bb64c
to
1213051
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Update: #58608 moved the font library classes to the 6.5 compat directory. Due to subsequent refactoring and modifications, it seems that it is no longer necessary to fix PHP files. Ultimately, this PR applies the translation function to only one place of text present in the Javascript file. |
|
I think it is essential for this text to be translated in WP6.5, so I will give it a backport label. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: creativecoder <[email protected]> Co-authored-by: matiasbenedetto <[email protected]>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 00f7e12 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: creativecoder <[email protected]> Co-authored-by: matiasbenedetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I noticed that some text in files related to the Font Library is not translatable.
How?
Along with adding translation functions, I changed the text domain fromdefaulttogutenberg.Testing Instructions
All GitHub Actions should be green. These texts probably don't exist in core or Gutenberg, so if you change the language of your site, they shouldn't still be localized.