Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44116
What?
Set the themed foreground color as the
color
for the wrapper div on theTheme
component.Why?
While working on #58014, I noticed that the
Theme
component does not set the foreground color as acolor
for its wrapper div.How?
Sets
currentColor
as the fallback when--wp-components-color-foreground
is not defined. This can happen when the consumer has not provided abackground
prop on Theme.I briefly considered falling back to
GRAY[ 900 ]
, but that would probably be a bit too intrusive 🤔 We can revisit this if necessary.Testing Instructions
Look at a Storybook story with some text that is not explicitly colored, e.g. the
View
component.Using the Theme switcher in the toolbar, try out the different presets.
background
color, the text color should responsively change to either#ffffff
or#1e1e1e
depending on the background.accent
color, the text color will stay as#000000
(=currentColor
).CleanShot.2024-01-23.at.06.45.17.mp4