Set post editor sidebar tabs to manual activation #58041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +143 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
chad1008
force-pushed
the
tabs-editor-settings-manual-activation
branch
from
5c66b31
to
cdb9102
Compare
|
Flaky tests detected in 2e2b03a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7636209195
|
chad1008
force-pushed
the
tabs-editor-settings-manual-activation
branch
from
cdb9102
to
2e2b03a
Compare
chad1008
force-pushed
the
tabs-editor-settings-manual-activation
branch
from
2e2b03a
to
5dfdeb2
Compare
chad1008
added
[Type] Bug
ciampo
approved these changes
Feb 2, 2024
packages/edit-post/src/components/sidebar/settings-sidebar/index.js
Outdated
Show resolved
Hide resolved
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
changed the title
chad1008
force-pushed
the
tabs-editor-settings-manual-activation
branch
from
1f2c4f8
to
7ae8f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should wait for #57696 to be merged ✅
What?
Why?
When #55360 was merged to implement the new
Tabscomponent instead of the custom implementation in place previously, the activation method was changed. Previously, thebuttonelements needed to be explicitly activated to select a tab. With that PR the activation became automatic whenever a tab was given focus.In we noticed that automatic activation is more consistent with past behavior when migrating similar settings panels, and this change will bring them all in alignment (see #56959 and #57886)
Regarding tab flow: in the editor sidebars a race condition exists where if no tab is selected, and then the Tab key is used to cycle through all of the existing blocks, the next press of Tab will move focus to the settings sidebar.
When that happens, two events fire independently of each other in this order:
interfaceStoredetects that focus is no longer on a block. The sidebar is automatically switched over the the Post tab.The net result from a user perspective is that pressing Tab that last time focuses one tab wile selecting the other. This feels really confusing, so we're adding a check to prevent that from happening.
How?
selectOnMovepropuseEffectcall that will checks to confirm that the currently selected tab matches the currently focused tab. if not, it updates browser focus so the user experience is Tabing onto the tab that actually gets selected.Testing Instructions