Block editor: don't register shortcuts for preview editors #57984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +832 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 19, 2024
ellatrix
commented
Jan 19, 2024
| @@ -70,6 +70,7 @@ export function BlockPreview( { | |||
| <ExperimentalBlockEditorProvider | |||
| value={ renderedBlocks } | |||
| settings={ settings } | |||
| inert={ true } | |||
There was a problem hiding this comment.
There's probably more that we can eventually do for "inert" editors, but this is a good start. @youknowriad I'd love your opinion here. I'm also unsure about the naming. Maybe inert makes it sound like you can't interact with it, but you'd need to fix that yourself.
There was a problem hiding this comment.
We already have a __unstableIsPreviewMode: true flag, we shouldn't be introducing a new one. For me it's just the same as "inert" prop here.
There was a problem hiding this comment.
Ah, I didn't know about __unstableIsPreviewMode
ellatrix
changed the title
|
Flaky tests detected in db65d2e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7588692300
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We don't need shortcuts in previews and registering these takes time and causes store updates.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast