-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Create @wordpress/interactivity-router
module
#57924
Merged
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
270aaa0
Copy the wp-each implementation
DAreRodz 09972e6
Scaffold files for wp-each e2e tests
DAreRodz 926da69
Process template nodes inside `toVdom()`
DAreRodz 7f2f6c3
Add tests for several list manipulations
DAreRodz 63fa0ef
Add a new test to implement
DAreRodz 5019c6e
Add SSRed elements in PHP
DAreRodz 7819728
Add SSRed elements to letters test
DAreRodz 9308769
Add more test cases
DAreRodz 13be90d
Test support for siblings in template
DAreRodz e90ddfc
Implement tests for wp-each on navigation
DAreRodz 4643f4b
Update changelog
DAreRodz 07a53b6
Add `wp-each` documentation
DAreRodz d6b0a4e
Separate the router from the rest of the runtime
DAreRodz fc423df
Import deps from interactivity module
DAreRodz 77bd06a
Add an entry point for the router
DAreRodz b3b3ebb
Register interactivity router module
DAreRodz e38ff22
Add the router module to query block dependencies
DAreRodz 227aa86
Cache regions on DOMContentLoaded
DAreRodz adf8203
Update query block view
DAreRodz 144c15c
Update e2e tests
DAreRodz f3a01ee
Make router module a dynamic dependency in tests
DAreRodz 6d245b3
Update tests using navigate
DAreRodz 82a9d4a
Expose `state` & `actions` from router module
DAreRodz cbf4d3e
Fix module dependency definition for tests
DAreRodz dd7131e
Fix php lint
DAreRodz 2e5d7e7
Refactor dynamic imports in tests
DAreRodz 8b517b8
Attempt to fix webpack config
DAreRodz 44d2a37
Update caniuse-lite package
sirreal ffdbdc9
Update snapshots
sirreal 0bf64e3
Cleanup DEWP name, ensure no dupe plugin
sirreal 5c1554f
fixup! Cleanup DEWP name, ensure no dupe plugin
sirreal 93a7ea6
fixup! fixup! Cleanup DEWP name, ensure no dupe plugin
sirreal 94dfd8c
Merge branch 'trunk' into try/interactivity-api-router-module
DAreRodz f752a94
Convert `navigate` and `prefetch` into actions
DAreRodz 5d55caa
Do not use generator for `prefetch`
DAreRodz 7999837
Add changelog entry
DAreRodz 7b9e112
Create @wordpress/interactivity-router package
DAreRodz d09960e
Update package-lock
DAreRodz 9916bea
Add the new package to the DEWP
luisherranz 1e6b1c5
Use module as the externals default in the experimental module suppor…
luisherranz 3e50a84
Revert "Update package-lock"
DAreRodz e551609
Revert "Create @wordpress/interactivity-router package"
DAreRodz e1bf002
Remove unnecessary DEWP
DAreRodz 19185a3
Merge branch 'trunk' into try/interactivity-api-router-module
luisherranz 4e9d82a
Refactor for new Script Modules API
luisherranz f42d597
Fix router module name inside DEWP
DAreRodz f7596c2
Add DEWP to plugins
DAreRodz 337d22a
Revert "Revert "Create @wordpress/interactivity-router package""
DAreRodz 4dcfe20
Revert "Revert "Update package-lock""
DAreRodz 2534189
Update interactivity-router after reverts
DAreRodz 87e162d
Fix module dependencies in Query block
DAreRodz 1aaf239
Add changelog entry
DAreRodz c15686c
Fix typo
luisherranz d196e04
Revert adding externalsType in wp-scripts
luisherranz 980ad9b
Merge remote-tracking branch 'origin/try/interactivity-api-router-mod…
luisherranz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
package-lock=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. --> | ||
|
||
## Unreleased | ||
|
||
### Breaking changes | ||
|
||
- Initial version. ([57924](https://github.com/WordPress/gutenberg/pull/57924)) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of change that I'd like us to improve as part of adding these new modules, we should be adding hacks like this when we create new packages/modules. Instead we should have everything taken care of automatically. How can we do that here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, all the WordPress packages should be available as modules. Once that's done, we can update this to do something similar to what's done for scripts and make any module that starts with
@wordpress
external.