Modified Date Block: Don't render change date tool #57914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #57883
What?
This PR does not display the "Change Date" tool when the "Display last modified date" option is enabled.
Why?
This feature was originally intended for changing the publish date. The modified date is automatically determined and this tool does not actually work.
How?
Check
displayTypeand conditionally render.Testing Instructions
P.S. To check file diff, the link below with "Hide whitespace" enabled will be helpful.
https://github.com/WordPress/gutenberg/pull/57914/files?diff=unified&w=1