Interactivity API: Update preact, @preact/signals and deepsignal dependencies
#57891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
cbravobernal
changed the title
preact, @preact/signals and deepsignal dependencies
47 tasks
|
Size Change: +333 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
SantosGuillamot
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
I've tested it and it seems the fix I introduced with this workaround is not needed anymore 👏 What I tested:
- On first load: the
roleandaria-modalattributes are not present. - Open the menu: the
roleandaria-modalappear. - Close menu: the
roleandaria-modaldissapear.
cbravobernal
force-pushed
the
update/upgrage-preact-version
branch
from
9036238 to
bb03b0e
Compare
luisherranz
added
the
[Feature] Interactivity API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrade Preact, Preact Signals and Deepsignal dependencies in Interactivity API.
Reverts #54608, as Preact now removes the role attribute if its value is null.
preactjs/preact#4136 has been closed in 10.18.0
Why?
Being updated is important, and even more if those updates allows the project to have less JS code.