Remove check-latest-npm validation #57797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
the
[Type] Task
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
ockham
approved these changes
Jan 12, 2024
sirreal
added
the
Backport to Gutenberg RC
sirreal
added a commit
that referenced
this pull request
Jan 15, 2024
Package publishing via GitHub Actions is currently broken because the actions are not passing the npm version check. This check was introduced when package-lock formats were changing frequently and causing issues. Those difficulties seem to have passed for the most part.
gziolo
pushed a commit
that referenced
this pull request
Jan 16, 2024
Package publishing via GitHub Actions is currently broken because the actions are not passing the npm version check. This check was introduced when package-lock formats were changing frequently and causing issues. Those difficulties seem to have passed for the most part.
scruffian
pushed a commit
that referenced
this pull request
Jan 17, 2024
Package publishing via GitHub Actions is currently broken because the actions are not passing the npm version check. This check was introduced when package-lock formats were changing frequently and causing issues. Those difficulties seem to have passed for the most part.
|
I just cherry-picked this PR to the release/17.5 branch to get it included in the next release: 143caa1 |
cbravobernal
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the
check-latest-npmvalidationCloses #57757
Why?
Package publishing via GitHub Actions is currently broken (Slack link, failed build) because the actions are not passing the npm version check.
I created #57757 with an alternate fix, but there's been a significant push to remove the npm version check completely so I've done that.
Testing Instructions
Code review should be sufficient.
You could install a different npm version on your machine, then run something like
npm dedupe; git add package-lock.json; git commit.