LinkControl: Remove unnecessary right padding of input fields #57784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Jan 12, 2024
Comment on lines
-122
to
-124
| const inputClasses = classnames( className, { | ||
| // 'has-no-label': ! hideLabelFromVision, | ||
| } ); |
There was a problem hiding this comment.
Minor refactoring: The conditional has-no-label class was originally commented out, so classnames is not needed.
t-hamano
commented
Jan 12, 2024
Comment on lines
-54
to
-59
| // If the input doesn't have a visible label then | ||
| // we need to expand the input itself to occupy | ||
| // the full available horizontal space. | ||
| .block-editor-link-control__search-input.has-no-label .block-editor-url-input__input { | ||
| flex: 1; | ||
| } |
There was a problem hiding this comment.
Minor refactoring: This style is unnecessary because the has-no-label class does not exist under any conditions.
|
Size Change: +3 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #56685
What?
This PR removes unnecessary right padding of input fields when there are "Action" buttons.
Why?
In #56685, the padding on the right side was increased to prevent text from covering the submit button. However, once the URL is submitted, this submit button does not exist.
How?
We can determine whether this submit button exists using the
showActionsvariable, that is, thehas-actionsclass. Use this class to override the right padding with the default value when there is no submit button.Testing Instructions