Fix misplaced ReactRefreshWebpackPlugin #57777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been removed from the modules config, not script config.
sirreal
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
sirreal
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Jan 11, 2024
sirreal
added
the
Backport to Gutenberg RC
sirreal
added a commit
that referenced
this pull request
Jan 15, 2024
Restore ReactRefreshWebpackPlugin to @wordpress/scripts webpack config. #57461 accidentally moved the plugin to the modules config. It should have remained in the scripts webpack config and not been included in the modules config.
gziolo
pushed a commit
that referenced
this pull request
Jan 16, 2024
Restore ReactRefreshWebpackPlugin to @wordpress/scripts webpack config. #57461 accidentally moved the plugin to the modules config. It should have remained in the scripts webpack config and not been included in the modules config.
scruffian
pushed a commit
that referenced
this pull request
Jan 17, 2024
Restore ReactRefreshWebpackPlugin to @wordpress/scripts webpack config. #57461 accidentally moved the plugin to the modules config. It should have remained in the scripts webpack config and not been included in the modules config.
|
I just cherry-picked this PR to the release/17.5 branch to get it included in the next release: 79bb082 |
scruffian
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Restore ReatRefreshWebpackPlugin to @wordpress/scripts webpack config.
See https://github.com/WordPress/gutenberg/pull/57461/files#r1449177817
I haven't included a changelog entry because the package hasn't been published yet.
Why?
#57461 accidentally moved the plugin to the modules config. It should have remained in the scripts webpack config and not been included in the modules config.
Testing Instructions
Code review is sufficient.