DataViews: Add duplicate template pattern action #57638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
ntsekouras
requested review from
youknowriad,
talldan,
andrewserong and
aaronrobertshaw
|
Size Change: +147 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Jan 8, 2024
| @@ -283,3 +281,11 @@ | |||
| max-height: $grid-unit-60 * 2; // Adjust to not cover the save button, showing three items. | |||
| } | |||
| } | |||
|
|
|||
| .dataviews-action-modal__duplicate-template-part { | |||
There was a problem hiding this comment.
I didn't see where this class is added. I'm guessing it's generated. I wonder if we should rely on a generated class. I feel the "width" should be a prop of the modal and maybe a config in the action but that's for later.
There was a problem hiding this comment.
Yeah, it is generated and for now I wanted to avoid extra modal props in action. We can revisit soon with new actions needed.
There was a problem hiding this comment.
@ntsekouras @youknowriad can we do this differently, without using an internal dataviews class? I worry that by doing this kind of thing, the dataviews internal classes become public API.
There was a problem hiding this comment.
Personally I don't think it's bad to have a generated class name based on the unique action's id. I'm also not too concerned about indicating a public API as we can have breaking changes in Data Views.
Having said that, the alternative would be to have modalProps in actions API and that would also indicate public API. I think we'll know more when we are preparing for extending the APIs and update as needed then.
youknowriad
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the duplicate template action in the patterns page
Testing Instructions
CreateTemplatePartModalis used