Add Template Modal: Update scroll related layout #57617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: +10 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
@jasmussen Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #50595
What?
This PR adjusts the layout in the Add Template Modal, especially regarding scrolling. This will change the layout to look like this:
When there are many list items
When the number of list items is small
Why?
In #50595, the height of the suggestion list seems to have been removed. This makes
overflow:scrollappear to no longer work.Furthermore, in the case of
overflow:scroll, horizontal and vertical scroll bars are always displayed on Windows.How?
I applied height again to the suggestion list. The button height is 56px unless the list item title is extremely long. I made the maximum height of the list to be exactly the same as these four buttons.
Furthermore, I limited the direction in which
overflowis applied to vertical only, and changedscrolltoauto. This will prevent unnecessary scroll bar from appearing on Windows OS.Testing Instructions
e882e31550dd5bd00356b8b3411098f2.mp4