File: Remove unnecessary synchronization effect #57585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
Mamaduka
requested review from
talldan and
t-hamano
and removed request for
ajitbohra
|
Size Change: -41 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
LGTM!
One thing to note is that the fileId is updated in the following scenario. This does not happen with trunk.
- Insert file block
- Upload file (
fileIdis updated based on the current blockclientId) - Save the post and reload the browser (block
clientIdwill change) - Upload another file
fileIdis updated
If we want to maintain the existing fileId, we may be able to do it as follows.
diff --git a/packages/block-library/src/file/edit.js b/packages/block-library/src/file/edit.js
index 528a488039..6b24565bdf 100644
--- a/packages/block-library/src/file/edit.js
+++ b/packages/block-library/src/file/edit.js
@@ -64,6 +64,7 @@ function FileEdit( { attributes, isSelected, setAttributes, clientId } ) {
const {
id,
fileName,
+ fileId,
href,
textLinkHref,
textLinkTarget,
@@ -120,7 +121,7 @@ function FileEdit( { attributes, isSelected, setAttributes, clientId } ) {
id: newMedia.id,
displayPreview: isPdf ? true : undefined,
previewHeight: isPdf ? 600 : undefined,
- fileId: `wp-block-file--media-${ clientId }`,
+ fileId: fileId || `wp-block-file--media-${ clientId }`,
} );
}However, since fileId is just a string needed for accessibility (id, aria-describedby), there may be no problem even if it is rewritten to upload the file 🤔
|
@t-hamano, right. The sting just needs to be set when there is a file. It's "safer" to update during every file selection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes an unnecessary side-effect for setting the
fileIdattribute.Why?
A similar synchronization effect should be a last resort when there's no clear event responsible for attribute creation. In this case, it can be absorbed by the
onSelectFileevent.Testing Instructions
fileIdattribute is correctly set.Testing Instructions for Keyboard
Same