Data views: Make title display in grid views consistent #57553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Experimental
|
Size Change: +864 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jan 8, 2024
oandregal
reviewed
Jan 8, 2024
| @@ -222,7 +222,7 @@ export default function PagePages() { | |||
| <VStack spacing={ 1 }> | |||
| <View | |||
| as="span" | |||
| className="edit-site-page-pages__list-view-title-field" | |||
| className="dataviews-view-grid__title-field" | |||
There was a problem hiding this comment.
This makes the dataviews-view-grid__title-field a public API. We need dataviews to handle it based on what's the primary field instead.
oandregal
reviewed
Jan 8, 2024
| @@ -165,7 +165,9 @@ function Title( { item, categoryId } ) { | |||
| ) } | |||
| <Flex as="span" gap={ 0 } justify="left"> | |||
| { item.type === PATTERN_TYPES.theme ? ( | |||
| item.title | |||
| <span className="dataviews-view-grid__title-field"> | |||
There was a problem hiding this comment.
Same comment as (also for changes below) https://github.com/WordPress/gutenberg/pull/57553/files#r1445053840
oandregal
reviewed
Jan 8, 2024
| @@ -103,7 +103,7 @@ function TemplateTitle( { item, viewType } ) { | |||
|
|
|||
| return ( | |||
| <VStack spacing={ 1 }> | |||
| <View as="span" className="edit-site-list-title__customized-info"> | |||
| <View as="span" className="dataviews-view-grid__title-field"> | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates some styles and classes to make it easier to apply consistent styles to titles in grid layouts. Also fixes title truncation.
Why?
Currently the titles in the pattern management view are inconsistent with the ones in pages and templates.
How?
Apply a new css class (
.dataviews-view-grid__title-field) in the relevant locations, and add styles topackages/dataviews/src/style.scss.Testing instructions
Before
Templates
Pages
Patterns
After
Templates
Note: Fixed truncation.
Pages
Note: Fixed truncation.
Patterns
Note: Consistent title color, weight, decoration. Here items that do not function as links have the default
font-weight.