Migrate 'datepicker' e2e tests to Playwright #57545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
commented
Jan 4, 2024
Comment on lines
+59
to
+61
| await expect( | ||
| page.getByRole( 'button', { name: 'Change date' } ) | ||
| ).toContainText( /^[A-Za-z]+\s\d{1,2},\s\d{1,4}/ ); |
There was a problem hiding this comment.
@kevin940726, @WunderBart, what do you think about this assertion? Would it suffice? 😅
There was a problem hiding this comment.
I think it might be easier to just parse the date 😆. Something like...
const dateString = await page.getByRole( 'button', { name: 'Change date' } ).textContent();
const date = new Date( dateString );
expect( date ).toEqual( datePickerDate );We can keep the regex to test the format once if we want to.
There was a problem hiding this comment.
Thanks for the example; I'll try it out later.
P.S. My understanding of this test is that they just assert that the date label switches from Immediately to an actual date. In my opinion, it shouldn't really matter if the date string matches.
There was a problem hiding this comment.
Tried the suggested path, but Date fails to parse the string returned by a locator.
There was a problem hiding this comment.
Judged from the test case, I think it's also asserting that the date in the datepicker is the same as the one shown on the button. Not sure if it matters though!
There was a problem hiding this comment.
I believe unit tests cover exact date assertions for the date-time components. Doing something similar usually ends up in ugly e2e test code 😅
Should we land the current migration version or try to make date assertions happen?
There was a problem hiding this comment.
If it's already covered by unit tests then absolutely! TBH, I think all of these cases can be tested in unit/integration tests 😆. I was just being conservative 😅.
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
|
Thanks for the feedback and review, @kevin940726 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
datepicker.test.jse2e tests to Playwright.Why?
See #38851.
Testing Instructions