Migrate editing-widgets to Playwright
#57483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Type] Automated Testing
kevin940726
requested review from
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: -747 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
migrate/editing-widgets-playwright
branch
from
d843c12 to
2465c47
Compare
kevin940726
force-pushed
the
migrate/editing-widgets-playwright
branch
from
2465c47 to
5cf39f6
Compare
Mamaduka
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Thank you, @kevin940726!
I just had two minor notes, but migration looks great. I like that we could also enable a few skipped tests 🎉
I discovered some bugs in the widgets screen during the migration.
Saw a few inline notes. Should we create separate issues for those?
Comment on lines
57
to
59
| await page | ||
| .getByRole( 'button', { name: 'Toggle block inserter' } ) | ||
| .click(); |
There was a problem hiding this comment.
Nit (not a blocker): Should we make the locator more specific?
await page
.getByRole( 'toolbar', { name: 'Document tools' } )
.getByRole( 'button', { name: 'Toggle block inserter' } )
.click();
Comment on lines
186
to
187
| // eslint-disable-next-line playwright/no-force-option | ||
| force: true, |
There was a problem hiding this comment.
Nit (not a blocker): It could be helpful in future to have reason for using force: true
There was a problem hiding this comment.
Turns out it's not doing what it seems, I refactored it 😅 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851. Migrate
editing-widgetsto Playwright.This is also the last missing piece to completely remove
puppeteer-testing-libraryfrom the project.Why?
See #38851.
How?
I discovered some bugs in the widgets screen during the migration. Also updated
insertBlockandgetBlocksto allow retrieving from a specified parent block.Testing Instructions
CI Should pass.
Screenshots or screencast
N/A