Gallery Block: Add random order setting #57477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Block] Gallery
|
Size Change: +60 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
geriux,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
aaronrobertshaw
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Nice work @t-hamano 👍
This tests really well for me. I left one minor suggestion as an inline comment below but I'll leave that up to you.
✅ Pasted shortcode is successfully transformed to a gallery with random order
✅ Transforming images to galleries and vice versa still works
✅ Manually creating a randomly order gallery works
✅ A randomly ordered gallery does have the order of its images changed on each load
✅ Fixture tests all pass
LGTM 🚢
Co-authored-by: Aaron Robertshaw <[email protected]>
|
Thank you. It will be great to have the random setting back again. |
|
🙌 |
|
Thank you a lot for this feature. Many issues out there request the order by random in one block or another... Could you please take one second to transport/migrate the solution approved here to solve its brother issue? -> #40481 Please please❤️.. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9701
What?
This PR adds a new "Random order" setting to the Gallery block.
Why?
The gallery shortcode has many options. The Gallery block substantially covers many of the shortcode options, as we can reorder the images inside. It also automatically inherits some options when pasting a shortcode. However, only random order cannot be achieved unless the additional setting is added.
How?
In addition to adding settings, I've made it so that the random option is inherited when a shortcode is converted to a block. In the future, we may support other values for
orderby(menu_order,title, etc.) andorderoptions.Testing Instructions
[gallery ids="1,2,3,4" orderby="rand"]Screenshots or screencast
449a58a83fd997d26d9072567b082f92.mp4