[Mobile] - Update E2E Tests related to the Writing flow #57460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 29, 2023 16:13
geriux
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.69 MB ℹ️ View Unchanged
|
geriux
removed
the
Mobile App - Automation
geriux
commented
Jan 2, 2024
packages/react-native-editor/__device-tests__/[email protected]
Outdated
Show resolved
Hide resolved
added 5 commits
January 2, 2024 12:41
…ate in some cases, which also expects the condition to be true.
fluiddot
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
LGTM 🎊 ! Thanks @geriux for adding new E2E tests to cover the writing flow test cases 🏅 !
I added some comments but none should block merging this PR.
Regarding the fixed issue related to showing/hiding the keyboard when adding/removing text-based blocks, I presume there's no easy way to check this via automated tests. I'm concerned that future changes might introduce a regression, especially if we update the focus/blur logic. Maybe we could cover this case as a manual test, WDYT?
packages/react-native-editor/__device-tests__/[email protected]
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/pages/editor-page.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/[email protected]
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/[email protected]
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-paragraph.test.js
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/[email protected]
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-device-actions.test.js
Outdated
Show resolved
Hide resolved
Instead of adding new manual tests, what if we add a new expectation in the "Splitting and Merging" tests to expect the keyboard to remain visible when splitting and merging text blocks? |
Yep, good idea, I agree it's better to add it as a new expectation. |
added 2 commits
January 3, 2024 18:56
… the logic to click on the title wrapper within the function
…on to avoid clicking on the wrapper on iOS if its set to true for cases where its already focused and the caret is at the desired position
Awesome, added them in wordpress-mobile/test-cases#158 |
This matches the behavior of the host app WP-Android.
fluiddot
changed the base branch from
trunk
to
rnmobile/fix/android-open-keyboard-after-focus
fluiddot
changed the base branch from
rnmobile/fix/android-open-keyboard-after-focus
to
trunk
…at/native-writing-flow-tests
|
Heads up that I merged changes from #57543 to address flaky tests related to the case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
This PR adds a new E2E test suite
Writing flow testsand merges the canary testsParagraphandHeadinginto it.Why?
To check for new cases related to the keyboard state and to verify existing ones like merging blocks or creating new blocks when using the
returnkey.How?
Adds new tests picked from #57070:
It provides a new option
initialTitleforinitializeEditorto pass a custom title to the editor, for these cases to be able to set it as an empty title.Adds new helpers needed for these tests:
getDefaultBlockAppenderElementgetEmptyTitleElementisBlockActionsMenuButtonDisplayedisImageBlockSelectedTesting Instructions
CI checks should pass on both Gutenberg and Gutenberg Mobile.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A