Make the Replace featured image button perceivable by assistive technologies #57453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: -7 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
I think this change certainly makes sense.
I tested it with NVDA on Windows. When I press the Tab key while the Featured Image panel button is in focus, the screen reader read the following.
trunk:
Featured image button expanded heading level 2
Edit or replace the image button The current image has no alternative text. The file name is: test-3.jpg
blank
clickable main landmark Editor settings region Post property page Remove button
This PR:
Featured image button expanded heading level 2
Edit or replace the image button The current image has no alternative text. The file name is: test-3.jpg
Replace button
Remove button
It is worth noting that in NVDA, the way the Remove button is read out has also changed, but I think this is originally correct.
|
@t-hamano thanks for your review. Yeah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57451
Follow-up to #50269
What?
The featured image 'Replace' button is (intentionally) hidden from assistive technology via an
aria-hidden="true"attribute. This is not recommended as the button is still focusable and in the tab sequence.Why?
There is no good way to hide interactive controls from assistive technologies and it's not recommended to do tha tin the first place. Generally, controls that are visually presented to users should also be available to screen reader users. Controls that are in the Tab sequence should never use
aria-hidden="true".How?
Remove
aria-hidden="true"from the Replace button.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast