Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/preferences tests #57443

Conversation

pooja-muchandikar
Copy link
Contributor

What?

Part of #38851.
Migrate preferences.test.js to its Playwright version.

Why?

Part of #38851.

How?

See MIGRATION.md for migration steps.

Testing Instructions

Run npm run test-e2e:playwright test/e2e/specs/editor/various/preferences.spec.js

@t-hamano t-hamano added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Dec 29, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Dec 29, 2023

@pooja-muchandikar, the tabs component of the settings sidebar was recently refactored (#55360), so you'll need to update the locators.

Unfortunately, I can't push on your branch, but I can create a new PR based on yours, including you as a co-author, so you're credited as a contributor.

Would that work for you?

@pooja-muchandikar
Copy link
Contributor Author

Sure @Mamaduka

Works for me 🙂

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 29, 2023
@Mamaduka Mamaduka removed their assignment Dec 29, 2023
@Mamaduka Mamaduka removed the [Status] In Progress Tracking issues with work in progress label Dec 29, 2023
@Mamaduka
Copy link
Member

Closing in favor of #57446.

@Mamaduka Mamaduka closed this Dec 29, 2023
@pooja-muchandikar pooja-muchandikar deleted the migrate/preferences-tests branch December 29, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants