Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block JSON schema: add renaming key to supports definition #57373

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Dec 26, 2023

Related to #54426

What?

This PR adds renaming key to supports definition in block.json schema.

Why?

To allow developers to design block.json with reference to the correct schema.

Testing Instructions

Create the following JSON file locally, specifying the JSON schema changed by this PR.

{
	"$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/block-json-schema-renaming/schemas/json/block.json",
	"apiVersion": 3,
	"name": "test/test",
	"title": "Test"
}

You should see the renaming key listed in the supports property.

image

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers [Feature] Blocks Overall functionality of blocks labels Dec 26, 2023
@t-hamano t-hamano self-assigned this Dec 26, 2023
@t-hamano t-hamano force-pushed the block-json-schema-renaming branch from 166bee8 to aaba922 Compare December 26, 2023 11:55
@t-hamano t-hamano marked this pull request as ready for review December 26, 2023 11:58
@t-hamano t-hamano force-pushed the block-json-schema-renaming branch from aaba922 to 8624ab8 Compare December 28, 2023 13:13
@t-hamano t-hamano closed this Dec 28, 2023
@t-hamano t-hamano reopened this Dec 28, 2023
@t-hamano t-hamano force-pushed the block-json-schema-renaming branch from 8624ab8 to 725b3fd Compare December 29, 2023 06:26
Copy link

Flaky tests detected in 725b3fd.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7354374181
📝 Reported issues:

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@t-hamano t-hamano merged commit 596b0d8 into trunk Jan 4, 2024
55 checks passed
@t-hamano t-hamano deleted the block-json-schema-renaming branch January 4, 2024 01:48
@github-actions github-actions bot added this to the Gutenberg 17.5 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants