Font Library: remove "has_font_mime_type" function #57364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @HrithikDalal! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
matiasbenedetto
added
[Type] Enhancement
matiasbenedetto
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Hi @HrithikDalal, thanks for the PR.
This looks good to me 🚀
Let's merge after all the CI checks pass.
This was referenced Dec 28, 2023
youknowriad
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the
WP_Font_Family_Utils::has_font_mime_type()function and its tests. It's no longer necessary. The mime type check of the downloaded/uploaded files is done by the core functionwp_handle_upload, and a custom check is no longer required.Why?
Issue reference - #54875
How?
This PR removes
WP_Font_Family_Utils::has_font_mime_type()references, definitions, and tests.Testing Instructions
Verify that the Font Library works as before. ( Screencast )
Screenshots or screencast