Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Ensure font is scaled on iOS when accessibility settings are changed #57339

Merged
merged 5 commits into from
Dec 22, 2023
Merged

[RNMobile] Ensure font is scaled on iOS when accessibility settings are changed #57339

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89dbd65
Ensure font is scaled as expected
Dec 22, 2023
60e287f
Revert accidental new line
Dec 22, 2023
061d327
Refactor code for readability/conciseness
Dec 22, 2023
cbb1078
Remove duplicate and incorrect 'let' declaration
Dec 22, 2023
d98f0b7
Refactor newFontSize init for clarity/conciseness
Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,13 +650,9 @@ class RCTAztecView: Aztec.TextView {
///
private func applyFontConstraints(to baseFont: UIFont) -> UIFont {
let oldDescriptor = baseFont.fontDescriptor
let newFontSize: CGFloat
let fontMetrics = UIFontMetrics(forTextStyle: .body)

if let fontSize = fontSize {
newFontSize = fontSize
} else {
newFontSize = baseFont.pointSize
}
let newFontSize = fontMetrics.scaledValue(for: fontSize ?? baseFont.pointSize)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about scaledValue 👏


var newTraits = oldDescriptor.symbolicTraits

Expand Down
Loading