Blocks: optimise parser by batch parsing HTML to DOM #57180
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +102 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6d51cc39891abba41dee9fceda56264e9c8d4c7a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7252963990
|
ellatrix
force-pushed
the
try/optimise-block-parser
branch
from
1c093c6 to
3b20769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It is much more efficient to make the browser parse all HTML of all blocks in one go. Quick testing shows that this speeds up the parser by ~2x.
Why?
1st run: -5.6% first block load
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast