Components: add unit test __experimentalExpandOnFocus unit tests for FormTokenField
#57122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
added
[Type] Automated Testing
|
Flaky tests detected in 333952b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7226853842
|
|
Thanks for adding the test! 😄 |
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
…r `FormTokenField` (#57122) * add unit test * add tests for suggestion visibility after selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds three new unit tests to
FormTokenFieldfor the__experimentalExpandOnFocuspropWhy?
Ensure the suggestion list expands (or not) appropriately depending on the value of this prop, and that it doesn't reopen when the component is blurred. See #57002
How?
The first two tests check that the suggestions respond properly to the logic updated in the above PR. This ensures that
__experimentalExpandOnFocusis true, selecting a visible suggestion will not close the suggestion list, because the component still has focus.A third test then confirms that clicking outside the bounds of the component does not cause the suggestion list to reopen, which was the specific regression addressed in the above PR.
Testing Instructions
Confirm the new tests pass