ToC: adapt to rich text value #57093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
Dec 15, 2023
| ) | ||
| headingAttributes.content | ||
| .toString() | ||
| .replace( /(<br *\/?>)+/g, ' ' ) |
There was a problem hiding this comment.
We could actually use headingAttributes.content.toPlainText as well now, then replace all \n with spaces. But right now we cannot absolutely guarantee that it will be a rich text value, I need to make a PR for that.
There was a problem hiding this comment.
I'm torn here because this code is already doing the very thing we don't want to do: treat HTML as a string and perform risky parsing on it.
while it was the case before that the content attribute was a string, it was still an HTML string, so we could have found a RichText way to extract the plaint text content.
in this specific case I'd rather we use toPlainText() and then ponder what to do about stringly-based code. for example, maybe adding the string methods only helps to perpetuate problems like this that are essentially longstanding type errors. having things crash early in the release cycle gives us a chance to update dependent code so that it remains more resilient in the future.
There was a problem hiding this comment.
The only reason why we'd add those methods would be to avoid errors
There was a problem hiding this comment.
more than simply call .toString() do we need to wrap all these in RichTextData.from( headingAttributes.content )?
for PRs like this we could then directly modify the content, and perform more semantic operations like .removeTags( 'br' ), or at a minimum call .toString() after jumping back into the RichText world
|
Size Change: +10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5b0a574. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7219049567
|
|
Updated the description to reference #43204 |
|
Btw, I also linked the wrong PRs, thinking it was in the GB repo. Fixed now to: wordpress-mobile/gutenberg-mobile#6462 |
|
Fixed in #57322. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the ToC to work with the rich text value (quick fix). See #43204 for the breaking change.
Together with wordpress-mobile/gutenberg-mobile#6462, it makes me wonder if we should add all the string methods as a compatibility layer. Cc @dmsnell.
Why?
How?
Testing Instructions
There's probably a few way to test, but here what I did:
Testing Instructions for Keyboard
Screenshots or screencast