Global styles: relocate revisions from fill to sidebar component #57034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar, so it doesn't need to be included via fill. This commit moves the button from ui.js to the sidebar component in the hope that it will make both maintenance and working with parallel states, e.g., style book visibility easier later.
ramonjd
added
[Type] Code Quality
|
Size Change: -12 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 88ee36d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7202576448
|
andrewserong
approved these changes
Dec 14, 2023
ramonjd
deleted the
update/global-styles-move-revisions-button-to-sidebar
branch
artemiomorales
pushed a commit
that referenced
this pull request
Jan 4, 2024
…ar, so it doesn't need to be included via fill. (#57034) This commit moves the button from ui.js to the sidebar component in the hope that it will make both maintenance and working with parallel states, e.g., style book visibility easier later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why? How?
The revisions button is a permanent member of the global styles sidebar, so it doesn't need to be included via fill.
This commit moves the button from ui.js to the sidebar component in the hope that it will make both maintenance and working with parallel states, e.g., style book visibility easier later.
Context: #56800 (comment)
Testing Instructions
Check that the global styles revisions button is still there 😄 and works as before.