Block: combine store subscriptions #56994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.62 kB (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3e3d83a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7201187131
|
youknowriad
reviewed
Dec 13, 2023
youknowriad
reviewed
Dec 13, 2023
| attributes, | ||
| isValid, | ||
| isSelected, | ||
| } } |
There was a problem hiding this comment.
Is there a world where we could slowly deprecate these props :P. The clientId should be enough for most filters :)
There was a problem hiding this comment.
Not sure :) I mean keeping them doesn't do much harm I think.
youknowriad
approved these changes
Dec 13, 2023
Mamaduka
reviewed
Mar 21, 2024
Comment on lines
+226
to
+230
| value={ { | ||
| wrapperProps: restWrapperProps, | ||
| isAligned, | ||
| ...context, | ||
| } } |
There was a problem hiding this comment.
@ellatrix, can we add a comment here explaining why there's no need to memoize the BlockContext value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Combines 3 store subscriptions into one. Reuses existing the context to pass down selected information from the block editor store.
The flow of data is now as follows:
BlockListBlockProvider.wrapperProps. We add this information also to the private context (as it was the case before this PR). Again we cannot use props because the next component (BlockEdit) is also a filtered component.BlockListBlockrenders theBlockEdit, which eventually callsuseBlockProps, where we can now make use of this private context. Again, this is the same as before, nothing new here.The difference is that all information selecting is lifted up. This time it is created by
BlockListBlockProvider, andBlockListBlockadds information to it instead.Why?
First run: -8.4% for type, negligible for load
Second run: -11.7% for type
Third run: -12.1% for type
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast