Docs: Fix {% end %} tab position to show the text #56735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atachibana
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
t-hamano
approved these changes
Dec 3, 2023
There was a problem hiding this comment.
LGTM 👍
The changes made in this PR are consistent with where this text was originally located.
|
@t-hamano |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#56561 has broght back non-js tabs, but one insertion point is wrong, obscuring a needed explanation.
This line of text describing the example below is embedded in the previous example's Output tab because of the wrong
{% end %}tab position.Refer 1st example's Input/Output tab of https://developer.wordpress.org/block-editor/how-to-guides/themes/theme-json/
cc: @ryanwelcher
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast