Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleGroupControl: react correctly to external controlled updates #56678

Merged
merged 5 commits into from
Dec 1, 2023
Merged

ToggleGroupControl: react correctly to external controlled updates #56678

merged 5 commits into from
Dec 1, 2023

Commits on Nov 30, 2023

  1. Add unit test to catch the bug to be solved

    @ciampo
    ciampo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    52f6d5a View commit details
    Browse the repository at this point in the history

  2. Use state instead of a ref to toggle controlled mode sooner

    @ciampo
    ciampo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    109be52 View commit details
    Browse the repository at this point in the history

  3. CHANGELOG

    @ciampo
    ciampo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    db3c78d View commit details
    Browse the repository at this point in the history

  4. CHANGELOG again

    @ciampo
    ciampo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e1e9d98 View commit details
    Browse the repository at this point in the history

  5. Switch to new suggested implementation

    @ciampo
    ciampo committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    749a884 View commit details
    Browse the repository at this point in the history