Migrate Is Typing Test to Playwright #56616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 'should not close the dropdown when typing in it' I switched the test method to use an existing block with a dropdown rather than add a dropdown with an input to the screen. This feels more like real e2e test usage.
jeryj
added
the
[Type] Automated Testing
jeryj
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: +453 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7022a5f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7033389246
|
kevin940726
approved these changes
Nov 29, 2023
Comment on lines
+44
to
+49
| // Tab to Start Blank Button | ||
| await page.keyboard.press( 'Tab' ); | ||
| // Select the Start Blank Button | ||
| await page.keyboard.press( 'Enter' ); | ||
| // Select the First variation | ||
| await page.keyboard.press( 'Enter' ); |
There was a problem hiding this comment.
Nit: Should we just move this setup inside insertBlock to create the block we want?
There was a problem hiding this comment.
I think it's not worth moving it to insertBlock for this case. I didn't see insertBlock accounting for other special circumstances, so I wouldn't want to change it for this instance.
| // Moving the mouse shows the toolbar. | ||
| await editor.showBlockToolbar(); | ||
| // Open the dropdown. | ||
| await page.getByLabel( 'Display settings' ).click(); |
There was a problem hiding this comment.
Nit: Could we change this to getByRole?
There was a problem hiding this comment.
Sure! I just used Playwright's locator picker for it. Is it preferable to use getByRole to force usage of a button here?
There was a problem hiding this comment.
Yep! getByRole is always preferred and TBH I haven't found a need to use other query functions yet. It's preferred because it communicates the intent well for readers, that we're clicking on a button rather than anything else.
There was a problem hiding this comment.
That makes sense. Thanks for explaining!
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
To simplify, the the test method for typing in dropdowns from a toolbar was switched to use an existing block with a dropdown rather than add a dropdown with an input to the toolbar manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrating is-typing e2e tests from puppeteer to playwright
Why?
Part of the larger migration effort in #38851, also because this test is failing in #56335 because of how the block toolbar is defined as visible or not.
How?
Testing Instructions
npm run test:e2e:playwright test/e2e/specs/editor/various/is-typing.spec.jsTesting Instructions for Keyboard
Screenshots or screencast