Update trash icon #56569
Merged
Update trash icon #56569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +1.1 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
I like it fine; other than the 0.25 placement on the "handle" of the can. We have to use .5 increments. |
|
Thanks for updating this icon, the existing icon has a big footprint and the wrong stroke width. That said, the silhouette feels a little bit busy with all the lines, I wonder if we can reduce. Do we need the "folds" to indicate bent metal in the center, or would it read as trash still if it did not have the vertical lines? Also, I wonder if the handle actually has to have a hole in it. Could the handle be flush with the lid? Like so:
These are just random icons I found on the web and only the handle is a suggestion here. No blockers on my end, but from my angle what's important to balance is this view here (thank you for testing and sharing that context):
If you squint, ideally the external link and trash can should be the same shade of gray blobs. Right now trash is a bit darker in that case. |
|
Here's a version that passes the squint test a bit better, and fixes the placement: 
@jasmussen imo the icon looks a bit top-heavy with a filled handle – that's one of my gripes with the current version. Please feel free to push any alternatives! |
|
I like that one, happy to try it! The handle may be too rounded now, perhaps a straight one with rounded edges instead of an oval? But otherwise, nice! |
|
It starts to verge a bit into 'battery' territory with the flat handle, at least to my eye: 
Top is flat handle, bottom is current as of this PR. |
|
Ah right. Sorry about the detours, and thanks for the iterations. Unless Rich objects, I think you can merge the rounded one. |
jasmussen
approved these changes
Nov 28, 2023
|
I'll merge. Happy to tweak in a follow-up if needed! |
jameskoster
added
Needs Figma Update
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the Trash icon
Why?
The current icon has a couple of issues:
These issues feel very clear when you see the icon next to others in the set, like in the new page management view:
A new icon
Let's design a new icon. Here are a few concepts I put together.
The one in the PR looks like this but I am by no means married to it:
Let's explore and discuss options :)