Dataviews: Add confirmation step before deleting a page #56504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Experimental
ntsekouras
requested review from
mcsf,
youknowriad,
oandregal and
jorgefilipecosta
ntsekouras
commented
Nov 24, 2023
| return status !== 'trash'; | ||
| }, | ||
| hideModalHeader: true, | ||
| RenderModal: ( { item: post, closeModal } ) => { |
There was a problem hiding this comment.
In essence the changes are:
- add
hideModalHeaderandRenderModal RenderModalabsorbs thecallback- use a plain object instead of a hook.
|
Size Change: +1.63 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2243916. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6980639723
|
derekblank
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Dataviews: Add confirmation step before deleting a page * Update component docs for DataViews --------- Co-authored-by: Miguel Fonseca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a confirmation modal before deleting a page in pages list(DataViews).
Testing Instructions