Global styles revisions: migrate API call to getRevisions() #56349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g *ThemeGlobalStyleRevision selector and action.
ramonjd
added
[Type] Enhancement
ramonjd
requested review from
nerrad,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +126 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Nice catch. I forgot that there's a limit of 10 not 100 now 😄 To achieve parity it has to be 100. I'll set it. |
ramonjd
commented
Nov 21, 2023
| 'globalStyles', | ||
| __experimentalGetCurrentGlobalStylesId(), | ||
| { | ||
| per_page: 100, |
There was a problem hiding this comment.
At the moment there's a limit of 100 revisions set by WP_REST_Controller
Limit the results per page to 100 until we can implement pagination. See:
Thanks to @andrewserong for reminding me 😴
andrewserong
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks for the update @ramonjd, that's all testing nicely for me now, and there's no warnings in the site editor about deprecated calls, either 👍
LGTM! ✨
ramonjd
deleted the
update/migrate-global-styles-revisions-to-new-api
branch
7 tasks
ramonjd
added a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Ho!
Now that the core data revisions API is merged, we can use it to fetch global styles revisions and deprecate the old stuff, namely the
*ThemeGlobalStyleRevisionselector and action.Why?
We must sacrifice in the name of progress.
Testing Instructions
Fire up the site editor, and make/save global styles changes.
Check that there are no regressions to the global styles revisions list, especially:
Here are some demonstration videos we prepared earlier:
2023-11-21.11.26.36.mp4
2023-11-21.11.25.03.mp4