Remove incorrect version from deprecated __nextHasNoMarginBottom prop of AnglePickerControl Component
#56336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiankaegy
added
[Type] Code Quality
fabiankaegy
force-pushed
the
fix/deprecation-of-angle-picker-control-margin
branch
from
42479db to
ce108f8
Compare
fabiankaegy
force-pushed
the
fix/deprecation-of-angle-picker-control-margin
branch
from
ce108f8 to
11e949d
Compare
|
This could be a breaking change. There's an ongoing discussion for similar prop #55401. |
|
I'd love to get rid of all those deprecated features that we already claim should have been removed, but I share @Mamaduka's concerns. |
fabiankaegy
force-pushed
the
fix/deprecation-of-angle-picker-control-margin
branch
from
59d5f32 to
bf2834c
Compare
fabiankaegy
changed the title
__nextHasNoMarginBottom prop from AnglePickerControl Component__nextHasNoMarginBottom prop of AnglePickerControl Component
|
Flaky tests detected in bf2834c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6956550560
|
Mamaduka
approved these changes
Nov 22, 2023
fabiankaegy
deleted the
fix/deprecation-of-angle-picker-control-margin
branch
|
Thanks @fabiankaegy 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the version when the deprecated
__nextHasNoMarginBottomprop will get removed fromAnglePickerControlcomponentWhy?
This prop was supposed to be deprecated as of WordPress 6.4. But since we don't have a clear process for deprecating APIs that shipped in WordPress core the removal is currently on hold. So this PR removes the incorrect version number when the prop will get removed.
How?
/
Testing Instructions
/
Testing Instructions for Keyboard
/
Screenshots or screencast
/